Repository navigation
Conversation
…s bound to it
DELETE /obp/v4.0.0/management/cascading/banks/{BANK_ID}/accounts/{ACCOUNT_ID}
now also removes the SCA challenges of every consent whose JWT views name the
account. The consents are read from the users who hold or can see the account,
before their account access rows are deleted. The bank cascade deletes each
account through the same code.
…llenge table The account cascade looked for consents through the users who hold or can see the account, which misses a Berlin Group consent whose first challenge is still unanswered: no PSU is bound to it yet. The consents are now read from the challenges that carry a consent id and kept when their JWT names the account. The test now uses such a Berlin Group consent instead of an authorised UK consent, whose challenge is deleted once answered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE /obp/v4.0.0/management/cascading/banks/{BANK_ID}/accounts/{ACCOUNT_ID}now also removes the SCA challenges of every consent bound to the account, such as the challenge of a Berlin Group consent whose PSU has started but not yet answered its authorisation. A consent names its accounts in the views of its JWT, so the cascade reads the consents that still have challenges, keeps those whose views name this bank and account, and deletes their challenges; the consents themselves are kept. The consents are found through their challenges rather than through users, so a consent with no PSU bound yet is covered. A consent bound to other accounts as well loses its challenges too, since they record the authorisation of the consent as a whole.DELETE /obp/v4.0.0/management/cascading/banks/{BANK_ID}deletes each account through the same code.DeleteAccountCascadeConsentChallengeTestlodges a Berlin Group consent for each of two accounts the PSU holds, starts each authorisation without answering it, deletes the first account and checks that only that consent's challenge is gone. It holds alongside #2959, which deletes a UK consent's challenge once it is answered.